Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy button for copying of encrypted secret #990

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

Kapture 2020-10-21 at 18 34 48

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Add a copy to clipboard button to the dialog for showing encrypted secret.

@nghialv
Copy link
Member

nghialv commented Oct 21, 2020

Nice. How about moving the copy button to the same line with the Encrypted secret data title?

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 27.05%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 77.63%. This pull request decreases coverage by -0.22%.

File Base Head Diff
src/components/sealed-secret-dialog.tsx -- 70.59% +70.59%

@nghialv
Copy link
Member

nghialv commented Oct 21, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 73c3905 into master Oct 21, 2020
@pipecd-bot pipecd-bot deleted the copy-button branch October 21, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants