Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always scroll to the bottom on terraform plans preview #4473

Closed
kurochan opened this issue Jul 10, 2023 · 7 comments · Fixed by #4482
Closed

Always scroll to the bottom on terraform plans preview #4473

kurochan opened this issue Jul 10, 2023 · 7 comments · Fixed by #4482
Labels
area/web kind/bug Something isn't working

Comments

@kurochan
Copy link
Contributor

**What happened**:
I have a problem with the feature terraform plans preview.
When I try to scroll back manually to check, it automatically scrolls to the bottom and I cannot check it.

What you expected to happen:
First time, it scrolls to the bottom. But after that, auto-scroll is disabled.

How to reproduce it:

capture.mp4

Environment:

  • control-plane version: v0.44.1
@kurochan kurochan added the kind/bug Something isn't working label Jul 10, 2023
@khanhtc1202
Copy link
Member

khanhtc1202 commented Jul 10, 2023

@kurochan
Copy link
Contributor Author

@khanhtc1202 The problem I point out did not occur in the play environment. That's strange 🤔

@khanhtc1202
Copy link
Member

TBH, I got this issue sometime, but it's quite weird and hard to reproduce (on dev and locally) 😓 Let me check around that part, but due to it's hard to reproduce, it's quite hard to figure out how to fix.

@kurochan
Copy link
Contributor Author

I found that this problem only occurs in multi-stage pipelines and when the pipeline is running.

@khanhtc1202
Copy link
Member

Oh, if in such case, it's the current spec. Every time the logs (of the stage) are updated, the stage log view will be updated/generated, and auto scroll to the bottom will be triggered. The point is to notify users that a new log has been added. Once the stage is finished, you can scroll wherever you want to.
https://github.com/pipe-cd/pipecd/blob/master/web/src/components/deployments-detail-page/log-viewer/log/index.tsx#L30-L32

@kurochan
Copy link
Contributor Author

Just to confirm, is it a specification that when the log of a later stage is updated, the scroll in the log of the stage that has already finished is also updated? Seems like unnatural behavior to me 🤔

@khanhtc1202
Copy link
Member

In such case, it's not, that would be counted as a bug 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants