Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.22 #4874

Open
14 tasks done
ffjlabo opened this issue Apr 17, 2024 · 1 comment · May be fixed by #4919
Open
14 tasks done

Update to Go 1.22 #4874

ffjlabo opened this issue Apr 17, 2024 · 1 comment · May be fixed by #4919
Labels
kind/enhancement New feature or request

Comments

@ffjlabo
Copy link
Member

ffjlabo commented Apr 17, 2024

What would you like to be added:

TODO:

  • Update the base image of Dockerfiles and go.mod in tools/
    • actions-gh-release
    • actions-plan-preview
    • codegen
  • Update the base image of Dockerfiles in docs/
  • Update go version in docs document.
  • Update env.GO_VERSION in github actions workflow definitions.
    • test.yaml
    • publish_image_chart.yaml
    • publish_binary.yaml
    • lint.yaml
    • test_tool.yaml
    • build.yaml
  • Update go.mod in the root of the repo.

memo

Cursor_と_All_releases_-_The_Go_Programming_Language

Why is this needed:

After Go 1.22, we don't need to consider the loop var scope.
https://go.dev/blog/loopvar-preview

@ffjlabo ffjlabo added the kind/enhancement New feature or request label Apr 17, 2024
@ffjlabo
Copy link
Member Author

ffjlabo commented May 20, 2024

I updated the TODO above.
These are based on the investigation of the github action workflow definitions and previous PRs for updating go version.

workflow definitions: .github/workflows/*

to 1.20.3

to 1.19

@ffjlabo ffjlabo linked a pull request May 20, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant