Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused declaration in Iteration/Format cause TS build error #133

Closed
selfrefactor opened this issue Jul 23, 2020 · 3 comments
Closed

Unused declaration in Iteration/Format cause TS build error #133

selfrefactor opened this issue Jul 23, 2020 · 3 comments
Labels
enhancement Improving something

Comments

@selfrefactor
Copy link

馃悶 Bug Report

Describe the bug

The original issue is selfrefactor/rambda#511

I am using ts-toolbelt but I ship part of its code within my library, so users receive full TS support out-of-the-box. The unused part IMap extends Map = NumberMap causes TS build error with following TS config:

"compilerOptions": {
        "noUnusedLocals": true,
        "noUnusedParameters": true
 },

Reproduce the bug

Repo: https://github.com/selfrefactor/rambda-tree-shaking

Folder: packages/rambda

Command: yarn build

Expected behavior

Build process completes with no errors.

Possible Solution

Remove the unused code.

Screenshots

Additional context

@millsp
Copy link
Owner

millsp commented Jul 23, 2020

Thanks for reporting this @selfrefactor. It's fixed!

@millsp millsp closed this as completed Jul 23, 2020
@selfrefactor
Copy link
Author

So again, there are unused variables that causes problems for me. Is there a way to add such check, so I don't have to trouble you every time?

@millsp millsp reopened this Oct 17, 2020
@stale
Copy link

stale bot commented Dec 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 18, 2020
@stale stale bot closed this as completed Dec 25, 2020
@millsp millsp removed the wontfix This will not be worked on label Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving something
Projects
None yet
Development

No branches or pull requests

2 participants