Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O.Optional removes non optional properties #135

Closed
xaviergonz opened this issue Jul 31, 2020 · 2 comments
Closed

O.Optional removes non optional properties #135

xaviergonz opened this issue Jul 31, 2020 · 2 comments
Assignees
@millsp
Labels
bug Something isn't working

Comments

@xaviergonz
Copy link

I think this is something new since the latest version

type AAA = O.Optional<
{
  values: number[],
  optValues: number[]
},
"optValues"
>

this only yields optValues?: number[] | undefined; and removes values
@millsp millsp self-assigned this Jul 31, 2020
@millsp
Copy link
Owner

millsp commented Jul 31, 2020

Thank you, I'm looking into it.

@millsp
Copy link
Owner

millsp commented Jul 31, 2020

And another bug is gone, thank you!

@millsp millsp added the bug Something isn't working label Jul 31, 2020
@millsp millsp closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millsp millsp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xaviergonz @millsp