Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable array merge #152

Open
jer-sen opened this issue Oct 9, 2020 · 3 comments
Open

Nullable array merge #152

jer-sen opened this issue Oct 9, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@jer-sen
Copy link

jer-sen commented Oct 9, 2020

馃悶 Bug Report

Describe the bug

With ts-toolbelt@8.0.7 and typescript@4.0.3 O.Merge<{ a: null | number[] }, { a: null | number[] }, 'deep'> doesn't return { a: null | number[] } instead it returns

{
    a: number[] | {
        [x: number]: number;
    } | null;
}
@millsp millsp added bug Something isn't working wontfix This will not be worked on labels Oct 9, 2020
@stale stale bot removed the wontfix This will not be worked on label Oct 9, 2020
@millsp millsp added the wontfix This will not be worked on label Oct 9, 2020
@millsp
Copy link
Owner

millsp commented Oct 9, 2020

Hi there, sorry about this! I'm closing this issue because it's going to be fixed in the future.
I can't fix it on this branch because the fix introduces breaking API changes and full array merging support. If you want to give it a shot:

npm install typescript@next --save-dev
npm install ts-toolbelt@next --save

Cheers

@millsp millsp closed this as completed Oct 9, 2020
@jer-sen
Copy link
Author

jer-sen commented Oct 9, 2020

Ok thanks. I gonna wait...

@millsp
Copy link
Owner

millsp commented Oct 9, 2020

It's a bit far in time (on Nov 17) . We release the next branch according to the TS iteration plan microsoft/TypeScript#40124 since we are continuously upgrading the codebase with the latest ts features. It's generally safe to use ts next. Watch out for the release.

Don't hesitate ask questions if you need some help with types or anything else 馃挴

@millsp millsp reopened this Sep 3, 2021
@stale stale bot removed the wontfix This will not be worked on label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants