Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when building since last deploy (9.1.7) #173

Closed
morganicx opened this issue Feb 1, 2021 · 5 comments
Closed

Error when building since last deploy (9.1.7) #173

morganicx opened this issue Feb 1, 2021 · 5 comments
Labels
bug Something isn't working limitation We're limited here needs investigation Extra info is needed

Comments

@morganicx
Copy link

morganicx commented Feb 1, 2021

I get a typescript error when building my project since the last deploy:

/node_modules/easy-peasy/node_modules/ts-toolbelt/out/index.d.ts
[INFO] TypeScript error in /builds/.../frontend/node_modules/easy-peasy/node_modules/ts-toolbelt/out/index.d.ts(983,46):
[INFO] Type expected.  TS1110
[INFO] 
[INFO]     981 |     ```
[INFO]     982 |     */
[INFO]   > 983 |     export type NumberOf<N extends number> = `${N}`;
[INFO]         |                                              ^
[INFO]     984 | }
[INFO]     985 | declare module "Any/_Internal" {
[INFO]     986 |     import { NumberOf as NNumberOf } from "Number/NumberOf";
[INFO] 
[INFO] 
@millsp millsp added the bug Something isn't working label Feb 1, 2021
@millsp millsp closed this as completed Feb 2, 2021
@millsp millsp reopened this Feb 2, 2021
@millsp
Copy link
Owner

millsp commented Feb 2, 2021

If you can switch to ts >= 4.1 while I provide a fix. It's very hard atm to do this, the release system was broken on these versions. But I'll investigate and publish a sane version manually.

@millsp
Copy link
Owner

millsp commented Feb 4, 2021

Fixing this will cause breaking changes, it's not easy because there is global scope pollution. If I fix this, people using global imports will break. If I don't, it breaks only for people that use two different versions of ts-toolbelt at the same time. This has been fixed in version 9.

@millsp millsp added limitation We're limited here needs investigation Extra info is needed labels Feb 4, 2021
@mesqueeb
Copy link
Contributor

mesqueeb commented Feb 7, 2021

what does it mean

people using global imports will break

@millsp
Copy link
Owner

millsp commented Feb 7, 2021

It means that doing imports like import Merge from "Object/Merge" would break if I fixed this. This is the reason why it is not allowed no longer in version 9, it caused module pollution.

@millsp
Copy link
Owner

millsp commented Feb 28, 2021

Closing this as it cannot be backwards-resolved but has been resolved in version 9.

@millsp millsp closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limitation We're limited here needs investigation Extra info is needed
Projects
None yet
Development

No branches or pull requests

3 participants