Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Copy formatted links to clipboard #30

Open
Vingolf opened this issue Feb 20, 2022 · 5 comments
Open

[Feature Request] Copy formatted links to clipboard #30

Vingolf opened this issue Feb 20, 2022 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@Vingolf
Copy link

Vingolf commented Feb 20, 2022

add an entry to the context menu when right-clicking on a link
to enable the use of favourite formats for links too.

If appropriate, add an option in the settings
to enable or disable this feature.

You created a very good add-on with Copy Selected Tabs to Clipboard
and I have several copy formats in use with it 👍

Vingolf

@piroor
Copy link
Owner

piroor commented Sep 11, 2022

It looks interesting but beyond the scope of this project, and it looks hard to make the feature compatible to both tabs and links - links don't have "description" and some other information.

If you seriously require the feature, you should fork this project for the feature.

@piroor piroor added the wontfix This will not be worked on label Sep 11, 2022
@Vingolf
Copy link
Author

Vingolf commented Sep 19, 2022

it looks hard to make the feature compatible to both tabs and links -
links don't have "description" and some other information.

The user might select any text and this text is used as the description for the link 🤔

Format Link is an firefox addon that uses a selected text for a link

@piroor
Copy link
Owner

piroor commented Sep 19, 2022

I meant that the "description" is a metadata provided by the author of the webpage (like <meta name="description" content="...">.) Templates shared between tabs and links will make things complicated.

Format Link is an firefox addon that uses a selectet text for a link

Yes, that is the answer. I recommend you to use the addon for in-page links together with this - basically I recommend Firefox users (and addon developers) to use/develop feature-oriented addons instead of all-in-one type addons. Mixing different context features blurs the concept and it will shorten project lifetime unwantedly.

@Vingolf
Copy link
Author

Vingolf commented Sep 20, 2022

Yes, that is the answer. I recommend you to use the addon for in-page links together with this - basically I recommend Firefox users (and addon developers) to use/develop feature-oriented addons instead of all-in-one type addons. Mixing different context features blurs the concept and it will shorten project lifetime unwantedly.

This is a profound argumentation and I think you can close this issue now ✅

@piroor piroor added help wanted Extra attention is needed and removed wontfix This will not be worked on labels Oct 6, 2022
@piroor
Copy link
Owner

piroor commented Oct 6, 2022

The largest my concern about this feature was: how should we manage formats for tabs and links. We had to define similar templates for tab and link, so I thought that it will painful for users.

And here is a good news. I recently introduced a new placeholder %ANY(value1, value2, ...)% which will be filled with the first effective value. With this feature we can define a format supporting both cases: tab and link, so adding new functionality to copy links with a format became easier.

If you write a patch to support context menu commands on links, I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants