Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nighlty] Unable to open bookmark entries by mouse clicks due to Bug 1354159 #1298

Closed
Fanolian opened this issue Jul 1, 2017 · 7 comments
Closed

Comments

@Fanolian
Copy link

Fanolian commented Jul 1, 2017

Short description

Since 2017-06-30 build, I cannot open bookmarks entries by left/middle clicks.
The corresponding error message in Browser Console is
TypeError: aView is undefined bookmark.js:501:6
Mozregression points to Bug 1354159 - Add a 'Bookmarks' button to the Library panel.

Steps to reproduce

  1. Start Nightly with clean profile.
  2. Install TST.
  3. Open a bookmark entry with left or middle click.

Expected result

A new page opens.

Actual result

Nothing happens. Browser Console shows TypeError: aView is undefined bookmark.js:501:6.
I can open a bookmark with right click -> Open (with a new tab/window/private window).

Environment

  • Platform (OS): Win 10 CU
  • Version of Firefox: Nightly 2017-06-30 build
  • Version (or revision) of Tree Style Tab: 0.19.2017062500a201909
@piroor piroor closed this as completed in 67fce9a Jul 12, 2017
@strigona
Copy link

This issue is now present in Firefox Beta 56.0b3 and is only present with TST installed.

@Guik
Copy link

Guik commented Aug 28, 2017

How can we install the fix on non Nightly FF ?

@strigona-worksight
Copy link

When this ticket was opened, Firefox Nightly was version 56, which has since transitioned to a beta release. There is no Web Extension release of Tree Style Tabs.

#1224 appears to be the Web Extensions ticket.

@Guik
Copy link

Guik commented Aug 28, 2017

Sorry I mean on Normal FF release v 56

@strigona-worksight
Copy link

There is no fix as far as I know.

@strigona-worksight
Copy link

For what it's worth, I didn't notice there was a commit associated to this ticket when it was closed. It's possible that the fix is not in a release yet, but I don't know for sure.

@strigona-worksight
Copy link

Fix was July 12, last release was June 15. I'd just wait it out - you can still open bookmarks by Right-Clicking them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants