Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to close collapsed tree in TST 3.5.0 #2564

Closed
echophantom opened this issue Apr 23, 2020 · 6 comments
Closed

Unable to close collapsed tree in TST 3.5.0 #2564

echophantom opened this issue Apr 23, 2020 · 6 comments
Labels

Comments

@echophantom
Copy link

Short description

When I try to close a collapsed tree and all of its child tabs, the dialog box that pops up is completely blank and cannot be clicked.

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Open a child tab of the current tab by clicking any link.
  4. Collapse the parent/root tab.

Your tab structure should look like this:
Tab example

  1. Close the collapsed parent/root tab to close the entire tree.

Expected result

Tab tree is closed.

Actual result

Popup window titled "about:blank Close Tabs?" is generated and takes focus, but is completely blank aside from the title. Can't do anything other than close the popup window, and tab tree isn't closed.

Rolling back to TST version 3.4.1 fixed this, so I believe the issue is due to the change to dialog boxes noted in the 3.5.0 version notes.

Environment

  • Platform (OS): MacOS Mojave 10.14.6
  • Version of Firefox: 68.6.1esr
  • Version (or revision) of Tree Style Tab: 3.5.0
@piroor
Copy link
Owner

piroor commented Apr 24, 2020

Hmm, something wrong on ESR68...

@piroor
Copy link
Owner

piroor commented Apr 24, 2020

After some research I've realized that a small change is required on ESR68. The commit c59c9c0 should fix this.

@piroor piroor added the fixed label Apr 24, 2020
@piroor
Copy link
Owner

piroor commented Apr 24, 2020

I've released 3.5.1. It will be downloadable after an editor's review.

@wvxwxvw
Copy link
Contributor

wvxwxvw commented Apr 24, 2020

Probably in the subject. I can not bookmark the tree. See the screenshot, it shows:

  1. Working instance,
  2. Test clean instance (empty profile), specifically checked on it,
  3. Hidden window, which can not be called, there is only a ghost in the preview of the taskbar.

Update 3.5.1 is still unsigned, so I have not checked the fix yet. I am writing just for information. Win7 x64, Firefox ESR 68.7 x64.

@wvxwxvw
Copy link
Contributor

wvxwxvw commented Apr 24, 2020

Could not resist. Installed unsigned. The problem has disappeared.

@piroor
Copy link
Owner

piroor commented May 5, 2020

TST 3.5.4 is now available, so I close this.

@piroor piroor closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants