Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different hashing algorithm/uuid for fingerprints #7

Closed
Kugelschieber opened this issue Aug 5, 2020 · 1 comment
Closed

Use different hashing algorithm/uuid for fingerprints #7

Kugelschieber opened this issue Aug 5, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Kugelschieber
Copy link
Member

Kugelschieber commented Aug 5, 2020

So that the fingerprint cannot be unhashed again.

This is not an issue as long as you (the user) don't decrypt the hashes and no one gets access to your database. Consumer IPs usually change after a while, as ISPs use IP pools for their customers.

@Kugelschieber Kugelschieber self-assigned this Aug 5, 2020
@Kugelschieber Kugelschieber added this to the 1.1.1 milestone Aug 5, 2020
@Kugelschieber Kugelschieber changed the title Use asymmetric hashing algorithm for fingerprint Use different hashing algorithm/uuid for fingerprints Aug 5, 2020
@Kugelschieber Kugelschieber added the enhancement New feature or request label Aug 5, 2020
@Kugelschieber Kugelschieber modified the milestones: 1.1.1, 1.2.0 Aug 5, 2020
@Kugelschieber
Copy link
Member Author

Not worth the effort, because:

  1. no untrusted person should get access to your database
  2. fingerprints are dropped when processed
  3. decrypting MD5 hashes, even if they are weak, takes effort and they only contain the IP and User-Agent of a visitor, which is toleratable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant