Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix types for TypeScript 4.7 #239

Merged
merged 3 commits into from Jun 21, 2023
Merged

fix: Fix types for TypeScript 4.7 #239

merged 3 commits into from Jun 21, 2023

Conversation

BlackGlory
Copy link
Contributor

The module's type definition file could not be found in some cases of TypeScript 4.7, this PR resolves the issue.

Reference: https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing

@BlackGlory
Copy link
Contributor Author

Any progress?

@drwpow
Copy link

drwpow commented Apr 13, 2023

This would fix a bug for me as well. I believe this is safe to merge without any downside (in general, it never hurts to expose more to exports, e.g. "*": "./*").

@metcoder95 metcoder95 changed the title Fix types for TypeScript 4.7 fix: Fix types for TypeScript 4.7 Jun 21, 2023
@metcoder95 metcoder95 merged commit a38fb29 into piscinajs:current Jun 21, 2023
10 checks passed
@BlackGlory BlackGlory deleted the patch-1 branch June 21, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants