Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add needsDrain property #368

Merged
merged 7 commits into from Jul 13, 2023
Merged

feat: add needsDrain property #368

merged 7 commits into from Jul 13, 2023

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Jun 30, 2023

Closes #126

Pendings

  • Testing
  • Documentation

@metcoder95 metcoder95 marked this pull request as ready for review June 30, 2023 11:37
README.md Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
test/post-task.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
test/post-task.ts Outdated Show resolved Hide resolved
RafaelGSS
RafaelGSS previously approved these changes Jul 6, 2023
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @ronag suggestion

src/index.ts Outdated Show resolved Hide resolved
metcoder95 and others added 7 commits July 13, 2023 22:41
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
@metcoder95 metcoder95 merged commit 2d49b63 into current Jul 13, 2023
10 checks passed
@metcoder95 metcoder95 deleted the feat/needDrain_property branch July 13, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add needDrain property
3 participants