Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.1 reset_from bug #1230

Closed
knownact opened this issue Mar 22, 2017 · 2 comments
Closed

1.0.1 reset_from bug #1230

knownact opened this issue Mar 22, 2017 · 2 comments

Comments

@knownact
Copy link

code should be:

def reset_from(self, other_model):
"""
Borrow shareable pre-built structures (like vocab) from the other_model. Useful
if testing multiple models in parallel on the same corpus.
"""
self.wv.vocab = other_model.wv.vocab
self.wv.index2word = other_model.wv.index2word

@Kreiswolke
Copy link
Contributor

Hi,
I've fixed that bug in my fork 1230. I've tested it in a simple notebook, it works and is ready to pull.

Thanks!

@tmylk
Copy link
Contributor

tmylk commented Mar 22, 2017

@Kreiswolke Thanks. please submit a pull request and include unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants