Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check .py code-style distinctly #1520

Closed
2 tasks done
menshikh-iv opened this issue Aug 4, 2017 · 1 comment
Closed
2 tasks done

Check .py code-style distinctly #1520

menshikh-iv opened this issue Aug 4, 2017 · 1 comment
Projects
Code cleanup

Comments

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Aug 4, 2017 •
edited

For current state, we run flake8 3 times (for each python version) and if we have any PEP8 issue, then all build will be failed. Also, sometimes for python3.6, I see problems with encoding of files (because flake8 check non-python files with unknown suffix .xyz that are not contained in the flake8 ignore list).

  • Check by flake8 only once distinctively (without running tests)
  • Remove "hot-fix" practice with non-py files
@menshikh-iv menshikh-iv added this to TODO in Code cleanup Aug 4, 2017
@menshikh-iv menshikh-iv moved this from TODO to In progress in Code cleanup Aug 4, 2017
@menshikh-iv menshikh-iv mentioned this issue Aug 4, 2017
Merged
@menshikh-iv
Copy link
Contributor Author

Resolved in #1522

@menshikh-iv menshikh-iv moved this from In progress to Done in Code cleanup Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Code cleanup
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@menshikh-iv