Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list of ignored problems for flake8 #1644

Closed
menshikh-iv opened this issue Oct 23, 2017 · 2 comments
Closed

Fix list of ignored problems for flake8 #1644

menshikh-iv opened this issue Oct 23, 2017 · 2 comments
Labels
bug Issue described a bug difficulty easy Easy issue: required small fix

Comments

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Oct 23, 2017

Now we using --ignore=E501,E731,E12,W503,E402 parameters for flake8, we can be more "strict" and reduce list of "ignored" checks

What this checks means (full list here)

Code Message Action (from us)
E501 line too long (>80 characters) remove (but need track size with adequate limit, like 120)
E731 do not assign a lambda expression, use a def remove
W503 line break occurred before a binary operator -
E402 module level import not at top of file remove
E12 Many checks ... remove (need to think about E121, E123, E126)

Related #1636

@menshikh-iv menshikh-iv added bug Issue described a bug difficulty easy Easy issue: required small fix labels Oct 23, 2017
@menshikh-iv
Copy link
Contributor Author

menshikh-iv commented Nov 7, 2017

For now, need to think about E12 group and (more important) make extended-E501.

@menshikh-iv
Copy link
Contributor Author

Last part fixed in #1721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue described a bug difficulty easy Easy issue: required small fix
Projects
None yet
Development

No branches or pull requests

1 participant