Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyedVectors importing keras instead of tensorflow.keras? #2842

Closed
vrmpx opened this issue May 16, 2020 · 3 comments · Fixed by #2937
Closed

KeyedVectors importing keras instead of tensorflow.keras? #2842

vrmpx opened this issue May 16, 2020 · 3 comments · Fixed by #2937
Milestone
4.0.0

Comments

@vrmpx
Copy link

vrmpx commented May 16, 2020

Hello there,

I got a super quick question regarding the function get_keras_embeddings of KeyedVectors.py. Is there a reason behind requiring keras package to be installed (specifically referring to these lines) instead of going through tensorflow 2.0 API (i.e., import tensorflow.keras)?
@vrmpx
Copy link
Author

vrmpx commented May 16, 2020

I just realized there is a PR addressing this particular issue (#2729)

@piskvorky
Copy link
Owner

Yeah, that PR is unfinished. Can you help fix it?

It won't get completed unless people who actually use these Keras workflow(s) assist.

@piskvorky
Copy link
Owner

Ping @vrmpx can you help?

@piskvorky piskvorky added this to the 4.0.0 milestone Jul 26, 2020
@piskvorky piskvorky mentioned this issue Aug 3, 2020
Closed
@piskvorky piskvorky mentioned this issue Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
2 participants
@piskvorky @vrmpx