Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 8.6 tag to 0.8.6 #2948

Closed
pabs3 opened this issue Sep 16, 2020 · 11 comments
Closed

rename 8.6 tag to 0.8.6 #2948

pabs3 opened this issue Sep 16, 2020 · 11 comments

Comments

@pabs3
Copy link
Contributor

pabs3 commented Sep 16, 2020

Problem description

There is a tag "8.6" in the repository that is between 0.8.7 and 0.8.5 in terms of when it was created, but it is missing the 0 at the start.

Steps/code/corpus to reproduce

git clone https://github.com/RaRe-Technologies/gensim.git
cd gensim
git tag | grep -v '^[0-3]'

Or load the github tags page:

https://github.com/RaRe-Technologies/gensim/tags?after=0.8.9

Versions

0.8.6

Suggested fix

git tag 0.8.6 8.6
git tag -d 8.6
git push --delete origin 8.6
git push --tags
@mpenkov
Copy link
Collaborator

mpenkov commented Sep 18, 2020

Done, thank you for including a suggested fix!

@pabs3
Copy link
Contributor Author

pabs3 commented May 25, 2021

@mpenkov looks like this weird 8.6 tag has re-appeared, although the 0.8.6 tag still exists. Could you delete the 8.6 tag again and try to figure out why it came back?

@mpenkov
Copy link
Collaborator

mpenkov commented May 25, 2021

@piskvorky @gojomo Could you guys please check that your local clones do not have an 8.6 tag? I suspect one of us has this tag lying around somewhere, and pushes it upstream occasionally.

Nobody else is able to push to upstream (right?) so I think it's one of us, anyway. I'll check my other machines for traces of this tag, too.

@piskvorky
Copy link
Owner

I had an 8.6 tag locally, deleted now. Sorry if I introduced a regression somehow!

@pabs3
Copy link
Contributor Author

pabs3 commented Nov 7, 2021

@mpenkov @piskvorky @gojomo I noticed that the bogus 8.6 tag has been reintroduced, please remove it again. The correct 0.8.6 tag is still present though. Please run these commands again on all of the systems where gensim developers push to the repo:

git tag -d 8.6
git push --delete origin 8.6

@mpenkov
Copy link
Collaborator

mpenkov commented Nov 7, 2021

@pabs3 Why does this matter to you?

@pabs3
Copy link
Contributor Author

pabs3 commented Nov 7, 2021

The 8.6 tag is clearly incorrect and it is strange that it keeps showing up despite getting deleted.

I'm in the process of packaging gensim and its dependencies for Debian so that my employer can use them. Part of the Debian package is the debian/watch file, which enables Debian to automatically check for newer versions of gensim. The 8.6 tag sorts newer than the other tags such as 4.1.2, so the uscan tool that Debian uses to check upstream versions will always find the bogus 8.6 tag instead of the actual latest tag. I've worked around this in the debian/watch file by making the regex not find 8.6 but it would be nice if I could remove the workaround so that if you do eventually make a real 8.6 tag, the watch file will find it.

@mpenkov
Copy link
Collaborator

mpenkov commented Nov 7, 2021

Yeah, I agree that it is strange. I'm not sure why it keeps reappearing. I suppose we could set up a workflow that notifies us whenever it gets pushed (and maybe even by whom) - it's just that dealing with this requires an amount of effort that is not proportional to the severity of the issue.

@pabs3
Copy link
Contributor Author

pabs3 commented Nov 7, 2021 via email

@pabs3
Copy link
Contributor Author

pabs3 commented May 5, 2022

I see the tag got removed again and hasn't come back, thanks for that!

@mpenkov
Copy link
Collaborator

mpenkov commented May 5, 2022

@piskvorky We should have mentioned that in the release notes, e.g. "killed phantom 8.6 tag with fire"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants