Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MalletWrapper load_word_topics() to return value #764

Closed
tmylk opened this issue Jun 29, 2016 · 2 comments
Closed

MalletWrapper load_word_topics() to return value #764

tmylk opened this issue Jun 29, 2016 · 2 comments
Labels
difficulty easy Easy issue: required small fix wishlist Feature request

Comments

@tmylk
Copy link
Contributor

tmylk commented Jun 29, 2016

load_word_topics() doesn't return anything but stores the word topics internally in self.wordtopics.

It shouldn't set internal vars, but rather return the result to the caller (train), who should then assign it to internal object attributes.

db70d04#commitcomment-18054588
@tmylk tmylk added wishlist Feature request difficulty easy Easy issue: required small fix labels Jun 29, 2016
tmylk referenced this issue Jun 29, 2016
@piskvorky
add topic printing to LdaMallet
db70d04
@bhargavvader
Copy link
Contributor

I'll take this up.

@bhargavvader bhargavvader mentioned this issue Jun 30, 2016
Merged
@bhargavvader
Copy link
Contributor

bhargavvader commented Jul 30, 2016 •
edited

@tmylk , you can close this issue now.

@tmylk tmylk closed this as completed Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty easy Easy issue: required small fix wishlist Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmylk @bhargavvader