-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compression not handled for GCS files #514
Comments
Thank you, @mpenkov. Yes, I can confirm it works for me on develop branch. Is there any estimate on when 2.0.1 will be released? |
Does this also fix the same issue for writing? I can currently read from a .gz file on GCS with no problem, but when I write it is writing uncompressed even thought the filename ends in .gz. |
Yes, it does - no issues with file compression on writing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem description
When reading gzip-encoded blob from GCS, file object returns compressed binary data instead of decompressed text.
Steps/code to reproduce the problem
Also, I was able to find root cause -
gcs.Reader
class not implements.name
attribute which causecompression.compression_wrapper
function to skip decompressing (becauseos.path.splitext(file_obj.name)
returns('unknown', '')
).Versions
Darwin-19.3.0-x86_64-i386-64bit
Python 3.7.7 (default, Mar 10 2020, 15:43:33)
[Clang 11.0.0 (clang-1100.0.33.17)]
smart_open 2.0.0
The text was updated successfully, but these errors were encountered: