Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate face culling problem #82

Closed
bvssvni opened this issue Oct 17, 2014 · 3 comments
Closed

Investigate face culling problem #82

bvssvni opened this issue Oct 17, 2014 · 3 comments
Labels
discussion draft

Comments

@bvssvni
Copy link
Member

bvssvni commented Oct 17, 2014

The y-axis points up in normalized OpenGL coordinates, but in absolute 2D coordinates it points down. This leads to triangles disappearing if not the right side is rendered.
@flodiebold
Copy link

I think the reason this wasn't noticed so far is because backface culling wasn't actually enabled: gfx-rs/gfx#412

Does piston::graphics need backface culling? Otherwise it should probably just be disabled.

@bvssvni
Copy link
Member Author

bvssvni commented Oct 18, 2014

I think it should draw both sides by default, to allow flipping one of the axis.

@bvssvni bvssvni mentioned this issue Oct 31, 2014
Closed
@bvssvni
Copy link
Member Author

bvssvni commented Dec 11, 2014

This should now be fixed.

@bvssvni bvssvni closed this as completed Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion draft
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flodiebold @bvssvni