-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lockfiles ? #72
Comments
The purpose with the examples is to show how to do stuff with the latest version and to introduce new users to Piston. |
We could add lockfiles and remove them later if there is any problem. |
I suggest not keeping lockfiles tracked. This will force us to keep the examples building under the current Master revision. |
I am also against tracking lockfiles. While I agree with the convention for most cases, piston-examples is specifically meant to display examples of how to use the latest version of piston. If we introduce lockfiles, that forces users to either match the included lockfiles (to be able to compile code derived from the examples) or figure out how to use piston from scratch. |
Ok, then we choose to not track them for now. Rationale #75 Closing this discussion. |
According to http://crates.io/faq.html#why-do-binaries-have-cargo.lock-in-version-control,-but-not-libraries? the convention is to checkin lockfiles for executables.
If we check in lockfiles for each of these examples then the only thing we have to worry about breaking builds is breaking changes from the nightlies. On the other hand fixing versions for Piston dependencies will likely lead to examples getting out of date.
I'm leaning towards adding them.
The text was updated successfully, but these errors were encountered: