Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lockfiles ? #72

Closed
maxsnew opened this issue Sep 16, 2014 · 5 comments
Closed

Add lockfiles ? #72

maxsnew opened this issue Sep 16, 2014 · 5 comments

Comments

@maxsnew
Copy link
Contributor

maxsnew commented Sep 16, 2014

According to http://crates.io/faq.html#why-do-binaries-have-cargo.lock-in-version-control,-but-not-libraries? the convention is to checkin lockfiles for executables.

If we check in lockfiles for each of these examples then the only thing we have to worry about breaking builds is breaking changes from the nightlies. On the other hand fixing versions for Piston dependencies will likely lead to examples getting out of date.

I'm leaning towards adding them.

@bvssvni
Copy link
Member

bvssvni commented Sep 17, 2014

The purpose with the examples is to show how to do stuff with the latest version and to introduce new users to Piston.

@bvssvni
Copy link
Member

bvssvni commented Sep 17, 2014

We could add lockfiles and remove them later if there is any problem.

@TyOverby
Copy link
Contributor

I suggest not keeping lockfiles tracked. This will force us to keep the examples building under the current Master revision.

@indiv0
Copy link
Member

indiv0 commented Sep 19, 2014

I am also against tracking lockfiles. While I agree with the convention for most cases, piston-examples is specifically meant to display examples of how to use the latest version of piston.

If we introduce lockfiles, that forces users to either match the included lockfiles (to be able to compile code derived from the examples) or figure out how to use piston from scratch.

@bvssvni
Copy link
Member

bvssvni commented Sep 19, 2014

Ok, then we choose to not track them for now. Rationale #75

Closing this discussion.

@bvssvni bvssvni closed this as completed Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants