Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code to read splits in the devkit, with tests #28

Open
Tracked by #20
AndreiBarsan opened this issue Apr 23, 2023 · 3 comments
Open
Tracked by #20

code to read splits in the devkit, with tests #28

AndreiBarsan opened this issue Apr 23, 2023 · 3 comments
Assignees
@una-dinosauria

Comments

@AndreiBarsan
Copy link
Contributor

No description provided.

@AndreiBarsan AndreiBarsan mentioned this issue Apr 23, 2023
Closed
9 tasks
@una-dinosauria
Copy link
Contributor

@AndreiBarsan sorry, could you please remind me how this is different from #27?

@AndreiBarsan
Copy link
Contributor Author

I think #27 just referred to storing the splits somehow, and I guess we settled on the bucket because they are a bit too big for the repo/package, right?

This PR would cover the actual loading of splits. Once #35 lands both should be solved!

@una-dinosauria
Copy link
Contributor

I guess we settled on the bucket because they are a bit too big for the repo/package, right?

Yep! Storing as text was taking 400+ MB, too much for a git repo IMO.

This PR would cover the actual loading of splits. Once #35 lands both should be solved!

Gotcha, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@una-dinosauria una-dinosauria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreiBarsan @una-dinosauria