Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad domain regex #48

Closed
U039b opened this issue Aug 13, 2021 · 3 comments
Closed

Bad domain regex #48

U039b opened this issue Aug 13, 2021 · 3 comments
Assignees
@evilcel3ri
Labels
bug Something isn't working

Comments

@U039b
Copy link
Member

U039b commented Aug 13, 2021

See the Network analysis of https://beta.pithus.org/report/7f4dda8c5131fe4f43112f696c1733bb93d3a9f6bef9e1aa4c87891b49874970

We should probably fix that directly in MobSF.
@U039b U039b added the bug Something isn't working label Aug 13, 2021
@evilcel3ri evilcel3ri self-assigned this Aug 13, 2021
@evilcel3ri
Copy link
Member

Ran the sample on MobSF locally didn't recreate the issue. WIll run this on Pithus locally to see if that can be recreated. Otherwise, maybe relaunching the analysis on the sample would do the trick if the bug cannot be reproduced.

@evilcel3ri
Copy link
Member

Wait, yes it recreates the bug. My bad. Going to look into MoBSF

@evilcel3ri
Copy link
Member

See #53

@evilcel3ri evilcel3ri mentioned this issue Aug 27, 2021
Closed
U039b added a commit that referenced this issue Sep 6, 2021
@U039b
Merge pull request #53 from Pithus/issue/48-bad-domain-regex
898bf3c 
Patch for filtering out unknown tld from the domains and url list #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evilcel3ri evilcel3ri

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evilcel3ri @U039b