Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a create zip function that replaces archivex #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added a create zip function that replaces archivex #36

wants to merge 1 commit into from

Conversation

dbathgate
Copy link

  • arhivex was not closing the zip file properly
  • This issue resulted in an error in windows in which the zip file is currently open by another process
  • archivex seemed to be unmaintained and had to recreate functionality inside zipper.go
  • Existing tests in zipper_test.go seemed sufficient enough to cover change

Resolves: #35

@dbathgate
added a create zip function that replaces archivex
01e9dc1 
- arhivex was not closing the zip file properly
- Resolves: #[35]
@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
unscheduled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tile rename step fails when running on windows
2 participants
@dbathgate @cf-gitbot