Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

jasmine:ci server doesn't execute tests #202

Closed
1000hz opened this issue Apr 9, 2014 · 5 comments
Closed

jasmine:ci server doesn't execute tests #202

1000hz opened this issue Apr 9, 2014 · 5 comments

Comments

@1000hz
Copy link

1000hz commented Apr 9, 2014

I'm on Rails 4.1 pointing bundler at this repo

Running rake jasmine:ci starts up the server, but phantomjs doesn't seem to kick off the test suite. The server just sits idle once started until I shut it down.

$ bundle exec rake jasmine:ci
Waiting for jasmine server on 51409...
Waiting for jasmine server on 51409...
Waiting for jasmine server on 51409...
Waiting for jasmine server on 51409...
[2014-04-09 11:51:18] INFO  WEBrick 1.3.1
[2014-04-09 11:51:18] INFO  ruby 2.1.1 (2014-02-24) [x86_64-darwin13.0]
[2014-04-09 11:51:18] INFO  WEBrick::HTTPServer#start: pid=79518 port=51409
Waiting for jasmine server on 51409...
jasmine server started.

The server is indeed started as I can hit it in my browser and the specs run fine.

@1000hz
Copy link
Author

1000hz commented Apr 9, 2014

Also, the phantomjs process is running.

@1000hz
Copy link
Author

1000hz commented Apr 11, 2014

I think this might be caused by #179, because I've been running into that bug too. 😟

@tjarratt
Copy link
Contributor

@1000hz that sounds really annoying. When I was investigating issues similar to #179 I added some instrumentation (read: puts statements) to jasmine-gem to find out if we were indeed being required and start multiple times. The fix for that issue is to find out where the multiple versions of jasmine are coming from, and remove the duplicates.

If that is indeed the problem you're seeing... excuse me while I wonder out loud ...

Would it be possible for the jasmine gem to detect when it's been required multiple times? Since this seems to happen frequently enough, solving this once might help prevent users from encountering this in the future.

@ragaskar
Copy link
Contributor

@tjarratt Seems reasonable; I would want it to throw a warning rather than exit-ing/raise-ing, just in case there's some legitimate reason to include jasmine twice. I'm not sure of a good way to do this, but we could just jam an instance variable somewhere.

@ragaskar
Copy link
Contributor

I'm going to close this because we now throw errors if you've include-d jasmine twice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants