Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated openapi spec #497

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Fix generated openapi spec #497

merged 1 commit into from
Sep 10, 2020

Conversation

djoyahoy
Copy link
Contributor

@djoyahoy djoyahoy commented Sep 8, 2020

  • Use string type for lastTransitionTime in the Condition schema as it does custom json encoding/decoding
  • Fix cluster object template for patches

- Use string type for lastTransitionTime in the Condition schema as it does custom json encoding/decoding
- Fix cluster object template for patches
@djoyahoy djoyahoy requested review from matthewmcnew, tylerphelan and sukhil-suresh and removed request for matthewmcnew September 8, 2020 21:30
@djoyahoy
Copy link
Contributor Author

djoyahoy commented Sep 8, 2020

Should generating the openAPI spec be documented, and if so, where?

@codecov-commenter
Copy link

Codecov Report

Merging #497 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files          74       74           
  Lines        3418     3418           
=======================================
  Hits         2311     2311           
  Misses        836      836           
  Partials      271      271           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 353f637...9beb2a3. Read the comment docs.

@djoyahoy djoyahoy merged commit 983c31b into master Sep 10, 2020
@djoyahoy djoyahoy deleted the fix-openapi-spec branch September 10, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants