Bump lifecycle to 0.9.2 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matthewmcnew
commented
Oct 21, 2020
matthewmcnew
commented
- Avoid bumping go.mod lifecycle to avoid bumping google/go-container-registry to avoid bumping k8s/client-go to 1.18.*
- Avoid bumping go.mod lifecycle to avoid bumping google/go-container-registry to avoid bumping k8s/client-go to 1.18.*
matthewmcnew
requested review from
elenorebastian,
tylerphelan,
sukhil-suresh,
tomkennedy513 and
djoyahoy
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 66.49% 66.45% -0.05%
==========================================
Files 74 74
Lines 2991 2990 -1
==========================================
- Hits 1989 1987 -2
Misses 719 719
- Partials 283 284 +1
Continue to review full report at Codecov.
|
elenorebastian
approved these changes
Oct 21, 2020
tylerphelan
approved these changes
Oct 21, 2020
| @@ -41,7 +41,7 @@ func main() { | |||
| flag.Parse() | |||
|
|
|||
| image, err := lifecycleImage( | |||
| "https://github.com/buildpacks/lifecycle/releases/download/v0.9.1/lifecycle-v0.9.1+linux.x86-64.tgz", | |||
| "https://github.com/buildpacks/lifecycle/releases/download/v0.9.2/lifecycle-v0.9.2+linux.x86-64.tgz", | |||
| cnb.LifecycleMetadata{ | |||
| LifecycleInfo: cnb.LifecycleInfo{ | |||
| Version: "0.9.1", | |||
There was a problem hiding this comment.
Why doesn't the lifecycle version need to change on line 47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.