Windows Support #546
Merged
Windows Support #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkennedy513
force-pushed
the
windows
branch
2 times, most recently
from
e28bb30
to
498f98c
Compare
matthewmcnew
commented
Jan 4, 2021
matthewmcnew
commented
Jan 4, 2021
tomkennedy513
force-pushed
the
windows
branch
3 times, most recently
from
e8f7c16
to
eefb495
Compare
matthewmcnew
commented
Jan 5, 2021
| @@ -3,7 +3,9 @@ | |||
| controller_image: gcr.io/controller | |||
| webhook_image: gcr.io/webhook | |||
| build_init_image: gcr.io/build-init | |||
| build_init_windows_image: gcr.io/cf-build-service-public/kpack/build-init-windows | |||
There was a problem hiding this comment.
Is the expectation that this is built/updated out of band of ./hack/release.sh?
There was a problem hiding this comment.
yes, at least for now. Maybe in the future we could conceivably build the images using something other than pack that could run on linux and still build the windows images
matthewmcnew
commented
Jan 6, 2021
matthewmcnew
commented
Jan 6, 2021
matthewmcnew
requested review from
tylerphelan,
tomkennedy513,
sukhil-suresh and
aemengo
tylerphelan
reviewed
Jan 6, 2021
tomkennedy513
force-pushed
the
windows
branch
2 times, most recently
from
bf6967e
to
357febe
Compare
tylerphelan
reviewed
Jan 7, 2021
matthewmcnew
commented
Jan 7, 2021
matthewmcnew
commented
Jan 7, 2021
matthewmcnew
commented
Jan 7, 2021
matthewmcnew
commented
Jan 7, 2021
|
What are are remaining issues with Windows?
|
aemengo
reviewed
Jan 8, 2021
tylerphelan
reviewed
Jan 8, 2021
tomkennedy513
force-pushed
the
windows
branch
4 times, most recently
from
1dc33c8
to
2729e9a
Compare
aemengo
approved these changes
Jan 13, 2021
- wait for dns on windows. This is dues to the fact that windows containers on docker don't start up without their network ready so we have to wait. we think that this can be removed when containerd is the default runtime. In the build-init binary we don't error on timeout because we assume that it timed out due to an incorrect host, so we want the normal error for that to still apply. - create network wait launcher binary. This is used to execute the lifecycle containers during the build after the network is ready in windows containers. it is built with build-init and copied to a shared volume during the prepare step. we also think this can be removed when containerd is the default runtime - Copy git repository to workspace directory becase clone directly to workspace was causing issues on Windows - add os to builder status - Update openapi spec with latest openapi gen binary - add windows images to controller yaml - caching is not currently implemented for windows builds because the DefaultStorageClass isn't always compatible with windows. This will require more investigation Co-authored-by: Tom Kennedy <ktom@vmware.com> Co-authored-by: Anthony Emengo <aemengo@vmware.com> Co-authored-by: Matthew McNew <mmcnew@pivotal.io>
tomkennedy513
force-pushed
the
windows
branch
from
2729e9a
to
f3eb817
Compare
sukhil-suresh
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.