Handle delegation roles when signing images with notary #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djoyahoy
force-pushed
the
notary-delegation-roles
branch
from
7c383a6
to
595e804
Compare
djoyahoy
requested review from
matthewmcnew,
tylerphelan,
sukhil-suresh,
tomkennedy513 and
aemengo
djoyahoy
force-pushed
the
notary-delegation-roles
branch
from
02b776c
to
0d28038
Compare
tylerphelan
reviewed
Dec 10, 2020
| @@ -39,28 +41,34 @@ func (a *AuthenticatingRoundTripper) RoundTrip(req *http.Request) (*http.Respons | |||
|
|
|||
| header := resp.Header.Get("www-authenticate") | |||
| parts := strings.SplitN(header, " ", 2) | |||
There was a problem hiding this comment.
should len(parts) == 2 be checked?
There was a problem hiding this comment.
I'm not checking it here because I assume the response is well formed as Bearer options.... That seems like a fair assumption to me, but I totally hear you.
tylerphelan
approved these changes
Dec 10, 2020
| #### Generate Signing Key | ||
| To generate a singing key, use the following commands from the [Docker Content Trust](https://docs.docker.com/engine/security/trust/#signing-images-with-docker-content-trust) documentation: | ||
| ```shell script | ||
| % export DOCKER_CONTENT_TRUST_SERVER=<notary-server-url> |
There was a problem hiding this comment.
Is there a reason to recommend the docker cli here vs notary?
There was a problem hiding this comment.
Using the docker CLI is significantly easier. I also suspect thats what most users will use.
| @@ -103,6 +111,15 @@ func (a *AuthenticatingRoundTripper) RoundTrip(req *http.Request) (*http.Respons | |||
| return a.WrappedRoundTripper.RoundTrip(req) | |||
| } | |||
|
|
|||
| func extractBearerOption(kind string, from string) (string, error) { | |||
| r := regexp.MustCompile(fmt.Sprintf(`%s="(.*?)"`, kind)) | |||
There was a problem hiding this comment.
Interesting evolution here as the result of multiple scopes.
matthewmcnew
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.