add intelligent windows tolerations based on node taints #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomkennedy513
commented
Jan 26, 2021
tomkennedy513
commented
- we only do this if the taints across all windows nodes are homogenous
tomkennedy513
force-pushed
the
intelligent-windows-tolerations
branch
from
68c61f6
to
f5a5800
Compare
tomkennedy513
force-pushed
the
intelligent-windows-tolerations
branch
3 times, most recently
from
53415a6
to
c3714a9
Compare
tomkennedy513
requested review from
aemengo,
sukhil-suresh,
tylerphelan and
matthewmcnew
|
should we do a provider pattern? |
aemengo
approved these changes
Jan 27, 2021
Comment on lines
+198
to
+204
| sort.Slice(taintsToCompare, func(i, j int) bool { | ||
| return taintsToCompare[i].Key < taintsToCompare[j].Key | ||
| }) |
There was a problem hiding this comment.
As an optimization, maybe we can move this second sort to be inside the func taintsEqual(, after the size check.
There was a problem hiding this comment.
i had that originally, but i changed it because even though its slightly less performant, i felt like it was a little weird to be sorting in the equals function, especially since i was only sorting one slice
tomkennedy513
force-pushed
the
intelligent-windows-tolerations
branch
from
c3714a9
to
6e68c99
Compare
aemengo
approved these changes
Jan 27, 2021
matthewmcnew
approved these changes
Jan 27, 2021
tylerphelan
approved these changes
Jan 27, 2021
- we only do this if the taints across all windows nodes are homogenous
tomkennedy513
force-pushed
the
intelligent-windows-tolerations
branch
from
6e68c99
to
16f65e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.