Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lifecycle to 0.10.2 & provide support for platform apis 0.5,0.4,0.3 #611

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Update lifecycle to 0.10.2 & provide support for platform apis 0.5,0.4,0.3 #611

merged 3 commits into from
Jan 29, 2021

Conversation

matthewmcnew
Copy link
Collaborator

@matthewmcnew matthewmcnew commented Jan 27, 2021 •
edited

  • Drop support for platform api 0.2
  • If using 0.4+ default the process type to web (identical to pack behavior)
  • Prevent notary/windows on platform api 0.3

Closes: #607

@matthewmcnew
Copy link
Collaborator Author

Perhaps we should validate that there is a supported platform api on builder creation. cc' @tylerphelan

@matthewmcnew
Copy link
Collaborator Author

matthewmcnew commented Jan 27, 2021 •
edited

When this rfc is implemented (likely in platform api 0.6) we can remove the default process type to web flag. This should be slightly more sensible behavior.

@matthewmcnew matthewmcnew marked this pull request as ready for review January 27, 2021 19:20
@tomkennedy513 tomkennedy513 self-requested a review January 27, 2021 19:21
@matthewmcnew
Support Platform apis 0.5,0.4,0.3
0df69e1 
- Drop support for platform api 0.2
- If using 0.4+ default the process type to web (identical to pack behavior)
- Prevent notary/windows on platform api 0.3
@matthewmcnew
Update shipped lifecycle to 0.10.2
2283b7c
@matthewmcnew matthewmcnew merged commit 3900cd9 into master Jan 29, 2021
@matthewmcnew matthewmcnew deleted the update-lifecycle branch January 29, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerphelan tylerphelan tylerphelan approved these changes

@tomkennedy513 tomkennedy513 tomkennedy513 approved these changes

@sukhil-suresh sukhil-suresh Awaiting requested review from sukhil-suresh

@aemengo aemengo Awaiting requested review from aemengo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update kpack lifecycle to 0.10.2.
3 participants
@matthewmcnew @tylerphelan @tomkennedy513