Added support for parsing ApplicationInfo from the manifest #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's hard to scan this online because the diffs are showing every line of every file changed (probably auto-reformatting from some editor). I expect that it'll be much easier once it's pulled down and from what I've seen of it so far it will be a pleasure. Thanks for including tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a response to missing ApplicationInfo support, and problems running Roboguice 1.1 with Robolectric (as reported here: http://groups.google.com/group/robolectric/browse_thread/thread/3e92bc828455d6e2, here: https://github.com/pivotal/robolectric/issues#issue/45 and here: http://groups.google.com/group/robolectric/browse_thread/thread/3d03a56bb595b7cc) I've updated the RobolectricPackageManager, added a couple of Shadow classes, modified RobolectricConfig to do the necessary manifest parsing and updated the tests accordingly.
In order for the RobolectricPackageManager to have access to the necessary manifest properties, I injected a new instance of the RobolectricConfig through the RPM constructor. As I'm new to the codebase, I'm not sure if this is the best way to do this...
This is my first time using Git/GitHub, and so I wasn't sure how to exclude changes I made to the pom from the pull request (which you can safely ignore).
Anyway, love the framework.
Rob