Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylsl wheels on pypi come with binaries, how do I build and include them in piwheels? #163

Open
cboulay opened this issue Oct 9, 2020 · 3 comments

Comments

@cboulay
Copy link

cboulay commented Oct 9, 2020

Package name: pylsl
Link to PyPI page: https://pypi.org/project/pylsl
Link to piwheels page: https://www.piwheels.org/project/pylsl
Version: all
Python version: all
I am the maintainer: Yes
More information:

  • Our current approach for deploying pylsl is to download our built platform-specific liblsl shared libraries and package them inside the wheel before uploading the wheel to pypi. This is handled by our AppVeyor script.

  • We do not currently have an apt-installable liblsl package. This library traditionally was used mostly to stream and sync data from hardware devices for which the only available drivers were in Windows, so there wasn't much need. But things are changing so maybe we should do this. But for now let's assume it isn't available.

  • liblsl can be built from source relatively easily with only cmake as a dependency. We have a build script that works on raspberry pi here. We should have a raspberry pi compatible .so file on our latest release fairly soon: https://github.com/sccn/liblsl/releases/tag/v1.14.0b4

Given the above, how do we get piwheels to (a) download this .so and drop it into the correct folder before building the wheel, or (b) build liblsl itself? If (b) is the better answer then can you please point me to a project that similarly downloads a 3rd party library source, builds it, then includes the .so in the wheel? Can this all be achieved by some setup.py magic?

Cheers,
Chad

@bennuttall
Copy link
Member

It's not really something we do, as piwheels is a very automated process. Alternatively, you can build the wheels and send to us for direct upload.

@cboulay
Copy link
Author

cboulay commented Jan 11, 2021

Is there an API or a web interface so we can upload the wheel without bothering you?
I don't have a wheel at the moment. Next time I fire up my pi I'll build it and attach it here.

@bennuttall
Copy link
Member

No API, we only do this for a couple of packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants