Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BriskBard #5528

Merged
merged 1 commit into from Sep 16, 2016
Merged

Added BriskBard #5528

merged 1 commit into from Sep 16, 2016

Conversation

da2x
Copy link
Contributor

@da2x da2x commented Aug 13, 2016

Added BriskBard browser.
Resolves #5525.

@coveralls
Copy link

coveralls commented Aug 13, 2016 •
edited

Coverage Status

Coverage remained the same at 98.545% when pulling 1ea1667 on Aeyoun:patch-3 into 03dffd3 on piwik:master.

@sgiehl
Copy link
Member

sgiehl commented Aug 20, 2016

Thx for the PR. Would you please add the new browser in the list of available browsers in https://github.com/piwik/device-detector/blob/master/Parser/Client/Browser.php#L29
and please also add a test to proof the detection works

@sgiehl sgiehl merged commit 1bf5ee4 into matomo-org:master Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@da2x @coveralls @sgiehl