fix Java 8 dependency, now compiles under Java 7 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcsorba
reviewed
Oct 31, 2016
|
|
||
| /** | ||
| * | ||
| * @author brettcsorba | ||
| */ | ||
| class CustomVariableList{ | ||
| private final Map<Integer, CustomVariable> map = new HashMap<>(); | ||
| private final ConcurrentHashMap<Integer, CustomVariable> map = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
There's not a need to have calls to the map be thread safe, so we inherit unnecessary overhead using a concurrent hash map. If we want to remove the call to putIfAbsent, we can refactor that logic to use containsKey/put in the while loop.
|
Thanks for the pull request, but I've resolved this with the approach I've outlined above. Thanks for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library almost compiles under Java 7, but
java.util.Maplacks aputIfAbsentmethod (added in Java 8). If we replace the regularMapwith aConcurrentHashMap(which does have this method), then it compiles fine.