Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming the Tracker class to PiwikTracker? #146

Closed
brototyp opened this issue May 25, 2017 · 1 comment
Closed

Renaming the Tracker class to PiwikTracker? #146

brototyp opened this issue May 25, 2017 · 1 comment
Labels
discussion swift
Milestone
4.0.0 Release

Comments

@brototyp
Copy link
Member

I just noticed the inconsistency that the main class that is used is named Tracker. The SDK is named PiwikTracker in the import as well as the cocoapod and many other places.

I think it would be best to rename the Tracker class to PiwikTracker.
@brototyp brototyp added this to the 4.0.0 Release milestone May 25, 2017
@thorstenstark
Copy link
Collaborator

Yeah, I agree that renaming it to PiwikTracker would be a good idea. Just Tracker makes it also hard for others reading the code to recognise it as the piwik tracker instead of some other tracker.

@brototyp brototyp mentioned this issue May 29, 2017
Merged
@brototyp brototyp closed this as completed Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion swift
Projects
None yet
Milestone
4.0.0 Release
Development

No branches or pull requests
2 participants
@brototyp @thorstenstark