Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install with Carthage. #190

Closed
thbaja opened this issue Oct 9, 2017 · 6 comments
Closed

Can't install with Carthage. #190

thbaja opened this issue Oct 9, 2017 · 6 comments
Assignees
Labels

Comments

@thbaja
Copy link

thbaja commented Oct 9, 2017

When trying to install via Carthage I encounter this:

> carthage update
*** Fetching piwik-sdk-ios
*** Checking out piwik-sdk-ios at "v4.2.0"
Parse error: expected submodule commit SHA in output of task (ls-tree -z v4.2.0 AFNetworking) but encountered:

Cartfile:
github "piwik/piwik-sdk-ios"

@brototyp
Copy link
Member

brototyp commented Oct 9, 2017

Hi @thbaja, thanks for the report. Is there more information after the encountered:?

@brototyp brototyp added the bug label Oct 9, 2017
@brototyp brototyp self-assigned this Oct 9, 2017
@thbaja
Copy link
Author

thbaja commented Oct 9, 2017

No, unfortunately not.
It seems that submodules can sometimes cause issues: Carthage/Carthage#135

@brototyp
Copy link
Member

brototyp commented Oct 9, 2017

Hi @thbaja, that was a good point. There was an old Submodule configured in the repository. I just deleted it and released it along with version 4.3.

@brototyp brototyp closed this as completed Oct 9, 2017
@elitalon
Copy link
Contributor

@thbaja Did this happen because you also had AFNetworking as a dependency or it just happens in general when installing piwik-sdk-ios with Carthage? The latter should've been caught when running build_with_package_manager in the CI 🤔

@brototyp
Copy link
Member

@elitalon I tested this issue yesterday by creating a new, empty Xcode project and adding the github "piwik/piwik-sdk-ios" to a Cartfile. So no other dependencies were necessary. Is this possibly an issue with just Xcode 9?

@brototyp
Copy link
Member

I just checked. Travis is testing on Xcode 9, so it can't be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants