Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Objective-C compatibility" header bigger #176

Merged
merged 2 commits into from Sep 10, 2017
Merged

Conversation

mattab
Copy link
Member

@mattab mattab commented Aug 6, 2017

No description provided.

@mattab mattab requested a review from brototyp August 6, 2017 21:57
@brototyp
Copy link
Member

brototyp commented Aug 7, 2017

What do you think about instead of making the header bigger to link this header from right from the top? Something like "written in Swift, [compatible with Objective-C](link to the header)"?

@brototyp
Copy link
Member

brototyp commented Sep 4, 2017

@mattab I just did that. Let me know if you are fine with this change.

@mattab
Copy link
Member Author

mattab commented Sep 6, 2017

👍

Maybe also rename "Advanced" to "Advanced usage" and make the title bigger, and the ones below too so they are bigger and there are less title levels.

@brototyp
Copy link
Member

Good point.

@brototyp brototyp merged commit 40e46d5 into develop Sep 10, 2017
@brototyp brototyp deleted the readme_header branch September 10, 2017 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants