Skip to content

Commit

Permalink
Fix invalid path in the permissions diagnostic
Browse files Browse the repository at this point in the history 
The path was absolute (/config) I don't know how it hasn't been reported yet
  • Loading branch information
@mnapoli
mnapoli committed Jul 21, 2015
1 parent d0c93e6 commit affd970
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugins/Diagnostics/Diagnostic/WriteAccessCheck.php
View file
Expand Up @@ -91,7 +91,7 @@ private function getDirectories()

if (! DbHelper::isInstalled()) {
// at install, need /config to be writable (so we can create config.ini.php)
$directoriesToCheck[] = '/config/';
$directoriesToCheck[] = 'config/';
}

return $directoriesToCheck;
Expand Down

8 comments on commit affd970

@odolhado
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes problems at installation step on checking rights to directories
eg. /srv/wwwconfig/

@mnapoli
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report, this is tracked in #8439

@mattab
Copy link
Member

@mattab mattab commented on affd970 Jul 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnapoli this really should have gone through a Pull request :-(

@mnapoli
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattab true, I wasn't expecting this kind of crap, the absolute paths above lead me wrong… And somehow I wasn't able to install Piwik because of this absolute path (but I have no idea why…)

@mattab
Copy link
Member

@mattab mattab commented on affd970 Jul 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact you had no idea why yet committed a fix to master, without a PR, hours before the release is not good idea... we will do another dot release

@mnapoli
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact you had no idea why yet committed a fix to master

At the time I thought I did (as explained above), which is why I committed the fix.

@quba
Copy link
Contributor

@quba quba commented on affd970 Jul 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys - maybe you should block the possibility to commit changes directly to master branch? Even though it was a human mistake, our workflow (or at least somebody from the team) should have detected this one.

@mattab
Copy link
Member

@mattab mattab commented on affd970 Aug 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quba that's one idea, likely we won't do it for now, but opened issue to discuss this: Should we block the possibility to commit changes directly to master branch? #8531

Please sign in to comment.