Remove tests that check translation files contain translator email #8668

matomo-org · Aug 31, 2015 · c63bdfb · c63bdfb
1 parent 508239b
commit c63bdfb
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/plugins/LanguagesManager/Test/Unit/TranslationWriter/Validate/CoreTranslationsTest.php b/plugins/LanguagesManager/Test/Unit/TranslationWriter/Validate/CoreTranslationsTest.php
@@ -61,15 +61,6 @@ public function getFilterTestDataInvalid()
                 ),
                 CoreTranslations::ERRORSTATE_TRANSLATORINFOREQUIRED
             ),
-            array(
-                array(
-                    'General' => array(
-                        'Locale' => 'de_DE.UTF-8',
-                        'TranslatorName' => 'name',
-                    )
-                ),
-                CoreTranslations::ERRORSTATE_TRANSLATOREMAILREQUIRED
-            ),
             array(
                 array(
                     'General' => array(

diff --git a/plugins/LanguagesManager/Test/Unit/TranslationWriter/WriterTest.php b/plugins/LanguagesManager/Test/Unit/TranslationWriter/WriterTest.php
@@ -103,8 +103,6 @@ public function getInvalidTranslations()
         return array(
             array(array('General' => array('Locale' => '')) + $translations, CoreTranslations::ERRORSTATE_LOCALEREQUIRED),
             array(array('General' => array('Locale' => 'de_DE.UTF-8')) + $translations, CoreTranslations::ERRORSTATE_TRANSLATORINFOREQUIRED),
-            array(array('General' => array('Locale' => 'de_DE.UTF-8',
-                                           'TranslatorName' => 'name')) + $translations, CoreTranslations::ERRORSTATE_TRANSLATOREMAILREQUIRED),
             array(array('General' => array('Locale' => 'invalid',
                                            'TranslatorName' => 'name',
                                            'TranslatorEmail' => 'name@domain.com')) + $translations, CoreTranslations::ERRORSTATE_LOCALEINVALID),

diff --git a/plugins/LanguagesManager/TranslationWriter/Validate/CoreTranslations.php b/plugins/LanguagesManager/TranslationWriter/Validate/CoreTranslations.php
@@ -20,7 +20,6 @@ class CoreTranslations extends ValidateAbstract
      */
     const ERRORSTATE_LOCALEREQUIRED = 'Locale required';
     const ERRORSTATE_TRANSLATORINFOREQUIRED = 'Translator info required';
-    const ERRORSTATE_TRANSLATOREMAILREQUIRED = 'Translator email required';
     const ERRORSTATE_LOCALEINVALID = 'Locale is invalid';
     const ERRORSTATE_LOCALEINVALIDLANGUAGE = 'Locale is invalid - invalid language code';
     const ERRORSTATE_LOCALEINVALIDCOUNTRY = 'Locale is invalid - invalid country code';
@@ -61,11 +60,6 @@ public function isValid($translations)
             return false;
         }
 
-        if (empty($translations['General']['TranslatorEmail'])) {
-            $this->message = self::ERRORSTATE_TRANSLATOREMAILREQUIRED;
-            return false;
-        }
-
         /** @var LanguageDataProvider $languageDataProvider */
         $languageDataProvider = StaticContainer::get('Piwik\Intl\Data\Provider\LanguageDataProvider');
         /** @var RegionDataProvider $regionDataProvider */