Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix missing translations in Goals plugin #1344

Closed
halfdan opened this Issue · 5 comments

2 participants

@halfdan
Collaborator

The Goals plugin didn't show the proper translation for it's menu items.

Reason:

  • Piwik_AddMenu was used without a proper translation string. (Goals_AddNewGoal)
  • No translation for menu item found -> Goals_Overview created.

Please add the line:
"Goals_Overview" => "Overview",

to the en.php.

@halfdan
Collaborator

Additionally add

'Goals_WhereThe' => 'where the',

to the en.php as the string "where the" was hardcoded in templates/form_add_goal.tpl.

Fixed in attachment.

@halfdan
Collaborator
@halfdan
Collaborator

I've overlooked the most obvious translation - the menu item. To summarise the changes:
Add:

'Goals_Overview' => 'Overview',
'Goals_Goals' => 'Goals',
'Goals_WhereThe' => 'where the',

to en.php and apply the last comitted diffs.

@halfdan
Collaborator

Attachment:
Goals.php.diff

@mattab
Owner

(In [2172]) Fixes #1344 thanks halfdan for patch!

@halfdan halfdan added this to the Piwik 0.6.2 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.