getProxy returns http expire header in the past, causing forced assets re-downloads #1887

mattab opened this Issue Dec 14, 2010 · 8 comments

3 participants

Piwik Open Source Analytics member

From the demo URL:

Expires header is in 1981, which causes all redownload of large asset file at every request.

Response headers were:

Date: Tue, 14 Dec 2010 04:47:50 GMT
Server: Apache
X-Powered-By: PHP/5.2.4-2ubuntu5.10
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: public, must-revalidate
Vary: Accept-Encoding,User-Agent
Content-Disposition: inline; filename=asset_manager_global_css.css
Last-Modified: Tue, 14 Dec 2010 04:44:39 GMT
Content-Type: text/css
Via: 1.1 bc4
Content-Length: 12406
Connection: Keep-Alive
Content-Encoding: deflate

My requests headers were

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv: Gecko/20101026 Firefox/3.6.12 (.NET CLR 3.5.30729)
Accept: text/css,*/*;q=0.1
Accept-Language: en-gb,fr;q=0.8,pt-br;q=0.6,fr-ca;q=0.4,en;q=0.2
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 3
Connection: keep-alive
If-Modified-Since: Tue, 14 Dec 2010 04:44:39 GMT
Cache-Control: max-age=0
Piwik Open Source Analytics member

do you see the same header in the response, which forces to re-download the assets every request?

Piwik Open Source Analytics member


Piwik Open Source Analytics member

Maybe the solution would be to have getAsset override the Expires header appropriately?


(In [3446]) fixes #1887 - override Expires header

Piwik Open Source Analytics member

Anthon, do you know why this issue started showing up recently and was not seen before?


In 1.0 we didn't have a proxy.

Piwik Open Source Analytics member

(In [3525]) adding unit test for refs #1887 comment:5

@mattab mattab added this to the Piwik 1.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment