Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Clean-up Windows Phone and Windows Mobile version detection #2824

Closed
mattab opened this Issue · 11 comments

3 participants

@mattab
Owner

See forum post: http://forum.piwik.org/read.php?3,83981

Let's check that the parsing algorithm will automatically detect further Windows Phone X updates in user agents.

@robocoder
Collaborator

OS detection algorithm is different from the browser detection algorithm.

It's not really future-proofable, eg win 3.1, win 95x, win 3.51, win nt4, win 2k, win xp, win vista, win 7 are derived from the product names.

@mattab
Owner

Thanks for the details, no problem if it's not future proof.

@robocoder
Collaborator

(In [5672]) refs #2824 - add placeholders for other Windows Phone and Windows Mobile versions (past & future); Windows operating systems are the only ones we identify by version ... why? also, Windows Phone market share is reportedly dropping; maybe we should drop the version number?

@robocoder
Collaborator

(In [5673]) fixes #2824

@sgiehl
Collaborator

Shouldn't we leave the old definitions and icons for already tracked data and only remove the detection?

Now already tracked data isn't displayed correct anymore after an update...

@robocoder
Collaborator

We're only striving for API backward compatibility. Theoretically, users can delete archives and re-trigger archiving to reprocess reports.

@mattab
Owner

Steve can you post a screenshot of what you experience (broken BC?) ?

Windows Phone market share is reportedly dropping; maybe we should drop the version number?

Definitely a good idea to drop Windows phone OS version number, since we don't track these for other phones

@sgiehl
Collaborator

Well, as an automatic update doesn't delete the images we removed in svn, the only thing that might be displayed "incorrect" is an old "short" name for windows phone os. (see screenshot)

@sgiehl
Collaborator

Attachment:
os.png

@mattab
Owner

I saw it on the demo too, I think it makes sense to display a better name rather than raise questions (people will think this is a bug for sure)

Anthon do you think it's a quick fix?

Cheers!

@mattab
Owner

(In [5748]) Fixes #2824
Restoring the display of Windows phones for backward compatibility.
Kuddos Anthon for fixing this ticket :)

@mattab mattab added this to the 1.7 Piwik 1.7 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.