Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Piwik.js] Refacto code #8642

Closed
dhoko opened this issue Aug 25, 2015 · 1 comment
Closed

[Piwik.js] Refacto code #8642

dhoko opened this issue Aug 25, 2015 · 1 comment
Assignees
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone

Comments

@dhoko
Copy link

dhoko commented Aug 25, 2015

Hi,

Why don't you split the source into severals files? 5792L in Piwik.js 馃憥
You can then build the source via browserify.

/* alias frequently used globals for added minification */
documentAlias = document,
navigatorAlias = navigator,
screenAlias = screen,
windowAlias = window,

We can remove these using a closure (to create a private scope too):

;(function(docAlias, winAlias, navAlias, screenAlias, undefined) {

// code 
})(document, window, navigator, screen);

What do you think ?

I can start to split the source if you want, I think the best way to begin is via the Query Object.

@tsteur tsteur added the duplicate For issues that already existed in our issue tracker and were reported previously. label Aug 26, 2015
@tsteur tsteur added this to the 2.15.0 milestone Aug 26, 2015
@tsteur tsteur self-assigned this Aug 26, 2015
@tsteur
Copy link
Member

tsteur commented Aug 26, 2015

Heya, closing it as duplicate of #6106 . It's possible to do and would be great to have but doesn't have much priority for us currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

2 participants