Fix possible twig error in updater if support is defined but no email #10501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Guess that needs to be fixed for 3.x as well? |
|
Yes, I have actually fixed it there directly in https://github.com/piwik/piwik/pull/10497/files#diff-6edb1c8f47dc8cbca0e88a41c1943137L108 to make the tests work. I removed it all because plugins are usually from Marketplace anyway and we do not want users to email us to get a copy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See eg http://builds-artifacts.piwik.org/piwik/piwik/10380/19911/ errors. If a plugin defines in
plugin.jsonegsupport: {"issues": "..."}it will fail because support is defined but no email. This can break the updater.