Define icon size for plugin icon in popup in visitor log #11271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another place where the icon size is not defined:
Unfortunately this shows a mistake I made when generating the new icons:
I replaced the white background with transparency to replicate the look of the old icons. But this also replaced white parts of the logos, which isn't visible normally but looks ugly on non-white backgrounds:
To fix it I would need to regenerate all icons and replace them either with non-transparent ones or use floodfill from one corner (which may create new issues if the background is not one connected background.
Of course there is also the "hack" of adding
background: white;
to the icons.