Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3 support #95

Closed
cpvannier opened this issue Feb 5, 2024 · 0 comments · Fixed by #93
Closed

Fix S3 support #95

cpvannier opened this issue Feb 5, 2024 · 0 comments · Fixed by #93
Assignees
@BertrandRenault
Labels
bug: minor Minor issues, minimal user impact scope: back Related to Pixano backend
Milestone
0.5.0

Comments

@cpvannier
Copy link
Member

cpvannier commented Feb 5, 2024 •
edited by BertrandRenault
Loading

Regressions:

  • an environment variable required by lancedb for S3 (AWS_ENDPOINT renamed ENDPOINT_URL)
  • URL images doesn't work anymore
@cpvannier cpvannier added bug: minor Minor issues, minimal user impact scope: back Related to Pixano backend labels Feb 5, 2024
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Feb 5, 2024
@cpvannier cpvannier linked a pull request Feb 5, 2024 that will close this issue
fix: S3 and URL wrongly handled #93
Merged
@cpvannier cpvannier mentioned this issue Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BertrandRenault BertrandRenault

Labels
bug: minor Minor issues, minimal user impact scope: back Related to Pixano backend
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

fix: S3 and URL wrongly handled pixano/pixano
2 participants
@cpvannier @BertrandRenault