Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem Scroll #4

Open
maicolreyes opened this issue Feb 18, 2016 · 2 comments
Open

Problem Scroll #4

maicolreyes opened this issue Feb 18, 2016 · 2 comments

Comments

@maicolreyes
Copy link

If i use multiple views inside a UIScrollView when I scroll, the ripple shows in the wrong side.
@Doublingli
Copy link

i did fix this problem by add the ripple layer into UIScroollView's content view.
wanna to pull and fix this bug

@karstenwuerth
Copy link

karstenwuerth commented Jul 12, 2017 •
edited
Loading

This is because the layer where the Ripple should show is set only one time in line 33: private static var targetLayer: CALayer?

-> A quick fix is to add in front of the line 159: var rippleLayer:CALayer? = targetLayer the line targetLayer = option.isRunSuperView ? view.superview?.layer : view.layer ... so the target layer will always be overwritten with the layer of the view which was clicked. To be honest I think this should be the default method ^^

@rmenezes rmenezes mentioned this issue Mar 11, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Doublingli @maicolreyes @karstenwuerth