Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use tt_address instead of fe_user for newsletter subscription. #9

Closed
extcode opened this issue May 29, 2017 · 7 comments
Closed

Comments

@extcode
Copy link

extcode commented May 29, 2017

We (TRITUM GmbH) use your extension for our newsletter subscription. Some new conditions will let us switch to tt_address instead of fe_user.

Our idea is to contribute some code to your extension to add a switch in the extension manager configuration to optional change the repository from fe_user to tt_address. Are you interested in this change or should we fork the extension for our own an change the repository directly for our projects?

@MattiasNilsson
Copy link
Contributor

@extcode That sounds like an awesome idea! We would really like to have this as a PR :)

@BastianBalthasarBux
Copy link

Any news on that? Would be a really great enhancement!

@extcode
Copy link
Author

extcode commented Nov 17, 2017

Yes. I have to do some cleanup and documentation.

@tritum
Copy link

tritum commented Feb 14, 2018

Why did extcode close this issue? We have developed the feature. I will take a look and will try to push a PR. Stay tuned.

@tritum
Copy link

tritum commented Feb 14, 2018

Can you please re-open this issue?

@anjeylink anjeylink reopened this Feb 14, 2018
@anjeylink
Copy link
Contributor

@tritum done

@tritum
Copy link

tritum commented Mar 2, 2018

#16

@dmh dmh closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants